types: add temperature threshold feature TMPTHH field#1007
types: add temperature threshold feature TMPTHH field#1007igaw merged 2 commits intolinux-nvme:masterfrom
Conversation
| */ | ||
| int nvme_set_features_temp_thresh(int fd, __u16 tmpth, __u8 tmpsel, | ||
| enum nvme_feat_tmpthresh_thsel thsel, | ||
| enum nvme_feat_tmpthresh_thsel thsel, __u8 tmpthh, |
There was a problem hiding this comment.
Unfortunately, this breaks the API.
There was a problem hiding this comment.
Okay I will do add a version 2 API instead. Thank you.
There was a problem hiding this comment.
yes, there is no other way :(
There was a problem hiding this comment.
Just added version 2 APIs instead. Thank you.
ikegami-t
force-pushed
the
temp-thresh-hyst
branch
from
8cd68b8 to
73e228c
Compare
| *thsel = NVME_FEAT_TT_THSEL(value); | ||
| } | ||
|
|
||
| static inline void nvme_feature_decode_temp_threshold2(__u32 value, __u16 *tmpth, |
There was a problem hiding this comment.
For the static inline function it is not necessary to introduce a new function. Just update the existing. We don't guarantee on source code level backwards compatibility. Just on binary interface.
There was a problem hiding this comment.
Understood so updated the patch again. Thank you.
ikegami-t
force-pushed
the
temp-thresh-hyst
branch
from
73e228c to
3259657
Compare
The field supported by NVMe revision 2.1. Signed-off-by: Tokunori Ikegami <[email protected]>
Those required to get the feature temperature values. Signed-off-by: Tokunori Ikegami <[email protected]>
|
Thanks! I've updated the export file and also renamed back the inline function. No need to change the name there. |
2 participants
The field supported by NVMe revision 2.1.